fix(knn): reapply sort after rescoring distances#4588
Open
sanikolaev wants to merge 1 commit into
Open
Conversation
sanikolaev
force-pushed
the
fix/knn-rescore-stable-order
branch
from
9536712 to
12501e9
Compare
sanikolaev
force-pushed
the
fix/knn-rescore-stable-order
branch
from
12501e9 to
262fdc0
Compare
sanikolaev
changed the title
sanikolaev
force-pushed
the
fix/knn-rescore-stable-order
branch
from
262fdc0 to
6b7bc79
Compare
Related issue #4320 KNN rescore now copies exact distances into the original knn_dist() sort key and reruns the original comparator, so explicit ORDER BY tie-breakers are respected for equal rescored distances.
sanikolaev
force-pushed
the
fix/knn-rescore-stable-order
branch
from
6b7bc79 to
d9e3698
Compare
Collaborator
Author
|
@glookka, previously there was another attempt to fix this issue, and you wrote.
The change in this PR fixes it according to your comment. Pls review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue #4320